From 0f244f1ced01df04830b739497503ad6f73decd2 Mon Sep 17 00:00:00 2001
From: Zoria <50277488+THZoria@users.noreply.github.com>
Date: Sat, 24 Jan 2026 21:15:06 +0100
Subject: [PATCH] Refactor firmware version check in workflow

---
 .github/workflows/firmware-autodl.yml | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/firmware-autodl.yml b/.github/workflows/firmware-autodl.yml
index cb6af2f..3789639 100644
--- a/.github/workflows/firmware-autodl.yml
+++ b/.github/workflows/firmware-autodl.yml
@@ -34,26 +34,16 @@ jobs:
       - name: 🔍 Check firmware version (Switch 1 only)
         id: version_check
         run: |
-          LATEST_TITLE=$(curl -s 'https://yls8.mtheall.com/ninupdates/feed.php' | \
-                         grep '<title>Switch ' | \
-                         grep -v '<title>Switch 2 ' | \
-                         head -n 1)
-
-          if [ -z "$LATEST_TITLE" ]; then
-            exit 1 
-          fi
-
-          LATEST_VERSION=$(echo "$LATEST_TITLE" | grep -oP 'Switch \K[0-9.]+')
+          LATEST_VERSION=$(curl -s 'https://yls8.mtheall.com/ninupdates/feed.php' | \
+                           grep -oP '<title>Switch \K[0-9.]+(?=</title>)' | \
+                           head -n 1)
 
           if [ -z "$LATEST_VERSION" ]; then
             exit 1
           fi
 
-          TAG_EXISTS=$(git ls-remote --tags origin $LATEST_VERSION)
-
-          if [ ! -z "$TAG_EXISTS" ]; then
+          if git rev-parse "$LATEST_VERSION" >/dev/null 2>&1; then
             echo "new_version=false" >> $GITHUB_OUTPUT
-            echo "Version $LATEST_VERSION already exists. Skipping."
           else
             echo "new_version=true" >> $GITHUB_OUTPUT
           fi