Fix firmware version check and update logic

Updated the firmware auto downloader workflow to improve release notes preparation and streamline version checking.

.github/workflows/firmware-autodl.yml

@@ -17,7 +17,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: 🐍 Setup Python and dependencies
+      - name: 🐍 Setup Python
         uses: actions/setup-python@v5
         with:
           python-version: '3.x'
@@ -31,37 +31,67 @@ jobs:
           cp hactool-linux hactool
           chmod +x hactool
 
-      - name: 🔍 Check firmware version (Switch 1 only, 21.0.0+)
+      - name: 🔍 Check firmware version (Switch 1 only, >=21.0.0 strict)
         id: version_check
+        shell: bash
         run: |
-          LATEST_TITLE=$(curl -s 'https://yls8.mtheall.com/ninupdates/feed.php' | \
-                         grep '<title>Switch ' | \
-                         grep -v '<title>Switch 2 ' | \
-                         grep -E 'Switch ([2-9][1-9]|[3-9][0-9])\.' | \
-                         head -n 1)
+          set +e
 
-          LATEST_VERSION=$(echo "$LATEST_TITLE" | grep -oP 'Switch \K[0-9.]+')
+          RSS=$(curl -sL --fail https://yls8.mtheall.com/ninupdates/feed.php)
+          CURL_STATUS=$?
 
-          if [ -z "$LATEST_VERSION" ]; then
-            echo "INFO: Aucune version récente (>= 21.x) trouvée."
+          if [ $CURL_STATUS -ne 0 ] || [ -z "$RSS" ]; then
+            echo "INFO: Impossible de récupérer le RSS."
             echo "new_version=false" >> $GITHUB_OUTPUT
             exit 0
           fi
 
-          echo "Version détectée : $LATEST_VERSION"
+          # Extraire description Switch (ignore Switch 2)
+          DESCRIPTION=$(echo "$RSS" | grep -oE '<description>Switch [0-9]+\.[0-9]+\.[0-9]+' | \
+                        grep -v 'Switch 2' | \
+                        head -n 1)
+
+          if [ -z "$DESCRIPTION" ]; then
+            echo "INFO: Aucun firmware Switch valide trouvé."
+            echo "new_version=false" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
+          echo "Description détectée : $DESCRIPTION"
+
+          VERSION=$(echo "$DESCRIPTION" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
+
+          if [ -z "$VERSION" ]; then
+            echo "INFO: Impossible d'extraire la version."
+            echo "new_version=false" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
+          MAJOR=$(echo "$VERSION" | cut -d. -f1)
+
+          # Autorise uniquement 21+
+          if [ "$MAJOR" -lt 21 ]; then
+            echo "INFO: Firmware $VERSION ignoré (<21.x)."
+            echo "new_version=false" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
+          echo "Version valide détectée : $VERSION"
 
           HTTP_STATUS=$(curl -s -o /dev/null -w "%{http_code}" \
             -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
-            "https://api.github.com/repos/${{ github.repository }}/releases/tags/$LATEST_VERSION")
+            "https://api.github.com/repos/${{ github.repository }}/releases/tags/$VERSION")
 
-          if [ "$HTTP_STATUS" == "200" ]; then
-            echo "INFO: La release $LATEST_VERSION existe déjà."
+          if [ "$HTTP_STATUS" = "200" ]; then
+            echo "INFO: La release $VERSION existe déjà."
             echo "new_version=false" >> $GITHUB_OUTPUT
           else
-            echo "INFO: Nouvelle version $LATEST_VERSION détectée !"
+            echo "INFO: Nouvelle version $VERSION détectée !"
             echo "new_version=true" >> $GITHUB_OUTPUT
+            echo "firmware_version=$VERSION" >> $GITHUB_OUTPUT
           fi
-        shell: bash
+
+          set -e
 
       - name: 💻 Execute download script and capture changelog
         id: download
@@ -72,11 +102,13 @@ jobs:
           echo "firmware_version=$FIRMWARE_VERSION" >> $GITHUB_OUTPUT
           tail -n 4 firmware_output.txt > changelog_body.txt
 
-      - name: 🧹 Clean .nca files
+      - name: 🧹 Clean and zip firmware
         if: steps.version_check.outputs.new_version == 'true'
         run: |
-          find . -type f -name "*.nca.*" -delete
           VERSION="${{ steps.download.outputs.firmware_version }}"
+
+          find . -type f -name "*.nca.*" -delete
+
           if [ -d "Firmware $VERSION" ]; then
             rm -f "Firmware $VERSION.zip"
             zip -rj "Firmware $VERSION.zip" "Firmware $VERSION/" -i "*.nca"
@@ -92,6 +124,8 @@ jobs:
             if (fs.existsSync('changelog_body.txt')) {
               const changelogBody = fs.readFileSync('changelog_body.txt', 'utf8');
               core.setOutput('release_body', changelogBody);
+            } else {
+              core.setOutput('release_body', 'No changelog available.');
             }
 
       - name: 📦 Create Tag and Release
@@ -108,7 +142,6 @@ jobs:
             **Downloaded file details:**
             
             ${{ steps.prepare_body.outputs.release_body }}
-            
           files: |
             Firmware ${{ steps.download.outputs.firmware_version }}.zip
         env: