Refactor firmware version check and download process

Refactor firmware download workflow for clarity and accuracy.

.github/workflows/firmware-autodl.yml

@@ -28,106 +28,90 @@ jobs:
 
       - name: ⬇️ Setup hactool-linux
         run: |
+          if [ -f "hactool-linux" ]; then
             cp hactool-linux hactool
             chmod +x hactool
+          else
+            echo "Warning: hactool-linux non trouvé."
+          fi
 
-      - name: 🔍 Check firmware version (Switch 1 only, >=21.0.0 strict)
+      - name: 🔍 Check firmware version (Switch 1 only, >=21.0.0)
         id: version_check
         shell: bash
         run: |
           set +e
-
           RSS=$(curl -sL --fail https://yls8.mtheall.com/ninupdates/feed.php)
-          CURL_STATUS=$?
+          if [ $? -ne 0 ] || [ -z "$RSS" ]; then
-
-          if [ $CURL_STATUS -ne 0 ] || [ -z "$RSS" ]; then
-            echo "INFO: Impossible de récupérer le RSS."
             echo "new_version=false" >> $GITHUB_OUTPUT
             exit 0
           fi
 
-          # Extraire description Switch (ignore Switch 2)
+          # Extraction stricte Switch 1 (hac) + Tri version
-          DESCRIPTION=$(echo "$RSS" | grep -oE '<description>Switch [0-9]+\.[0-9]+\.[0-9]+' | \
+          LATEST_VERSION=$(echo "$RSS" | tr -d '\n' | sed 's/<item>/\n<item>/g' | \
-                        grep -v 'Switch 2' | \
+            grep 'sys=hac' | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | sort -V | tail -n 1)
-                        head -n 1)
 
-          if [ -z "$DESCRIPTION" ]; then
+          if [ -z "$LATEST_VERSION" ]; then
-            echo "INFO: Aucun firmware Switch valide trouvé."
             echo "new_version=false" >> $GITHUB_OUTPUT
             exit 0
           fi
 
-          echo "Description détectée : $DESCRIPTION"
+          MAJOR=$(echo "$LATEST_VERSION" | cut -d. -f1)
-
-          VERSION=$(echo "$DESCRIPTION" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
-
-          if [ -z "$VERSION" ]; then
-            echo "INFO: Impossible d'extraire la version."
-            echo "new_version=false" >> $GITHUB_OUTPUT
-            exit 0
-          fi
-
-          MAJOR=$(echo "$VERSION" | cut -d. -f1)
-
-          # Autorise uniquement 21+
           if [ "$MAJOR" -lt 21 ]; then
-            echo "INFO: Firmware $VERSION ignoré (<21.x)."
             echo "new_version=false" >> $GITHUB_OUTPUT
             exit 0
           fi
 
-          echo "Version valide détectée : $VERSION"
+          # Check si la Release existe
-
           HTTP_STATUS=$(curl -s -o /dev/null -w "%{http_code}" \
             -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
-            "https://api.github.com/repos/${{ github.repository }}/releases/tags/$VERSION")
+            "https://api.github.com/repos/${{ github.repository }}/releases/tags/$LATEST_VERSION")
 
           if [ "$HTTP_STATUS" = "200" ]; then
-            echo "INFO: La release $VERSION existe déjà."
             echo "new_version=false" >> $GITHUB_OUTPUT
           else
-            echo "INFO: Nouvelle version $VERSION détectée !"
             echo "new_version=true" >> $GITHUB_OUTPUT
-            echo "firmware_version=$VERSION" >> $GITHUB_OUTPUT
+            echo "firmware_version=$LATEST_VERSION" >> $GITHUB_OUTPUT
           fi
-
           set -e
 
-      - name: 💻 Execute download script and capture changelog
+      - name: 💻 Execute download script
         id: download
         if: steps.version_check.outputs.new_version == 'true'
         run: |
-          python3 firmware_downloader.py | tee firmware_output.txt
+          python3 firmware_downloader.py
-          FIRMWARE_VERSION=$(grep 'Folder: Firmware ' firmware_output.txt | awk '{print $NF}')
+          VERSION="${{ steps.version_check.outputs.firmware_version }}"
-          echo "firmware_version=$FIRMWARE_VERSION" >> $GITHUB_OUTPUT
+          echo "firmware_version=$VERSION" >> $GITHUB_OUTPUT
-          tail -n 4 firmware_output.txt > changelog_body.txt
 
-      - name: 🧹 Clean and zip firmware
+      - name: 🧹 Clean and Generate Changelog
+        id: cleanup
         if: steps.version_check.outputs.new_version == 'true'
         run: |
           VERSION="${{ steps.download.outputs.firmware_version }}"
+          DIR="Firmware $VERSION"
           
-          find . -type f -name "*.nca.*" -delete
+          if [ -d "$DIR" ]; then
+            # Suppression des fichiers .1.nca et fragments
+            find "$DIR" -type f -name "*.[0-9].nca" -delete
+            find "$DIR" -type f -name "*.nca.*" -delete
 
-          if [ -d "Firmware $VERSION" ]; then
+            # Extraction des SystemVersion NCA (fichiers de ~128KB)
-            rm -f "Firmware $VERSION.zip"
+            # On cherche les fichiers NCA et on les trie par taille pour identifier les SystemVersion
-            zip -rj "Firmware $VERSION.zip" "Firmware $VERSION/" -i "*.nca"
+            SV_FAT=$(ls -S "$DIR"/*.nca | tail -n 2 | head -n 1 | xargs basename)
+            SV_EXFAT=$(ls -S "$DIR"/*.nca | tail -n 1 | xargs basename)
+
+            # Création du changelog personnalisé
+            echo "Archive created: Firmware $VERSION.zip" > changelog_body.txt
+            echo "SystemVersion NCA FAT: $SV_FAT" >> changelog_body.txt
+            echo "SystemVersion NCA exFAT: $SV_EXFAT" >> changelog_body.txt
+            echo "Verify hashes before installation!" >> changelog_body.txt
+
+            # Compression
+            zip -rj "Firmware $VERSION.zip" "$DIR/" -i "*.nca"
+          else
+            echo "Dossier non trouvé"
+            exit 1
           fi
 
-      - name: 📝 Prepare Release Body
-        id: prepare_body
-        if: steps.version_check.outputs.new_version == 'true'
-        uses: actions/github-script@v7
-        with:
-          script: |
-            const fs = require('fs');
-            if (fs.existsSync('changelog_body.txt')) {
-              const changelogBody = fs.readFileSync('changelog_body.txt', 'utf8');
-              core.setOutput('release_body', changelogBody);
-            } else {
-              core.setOutput('release_body', 'No changelog available.');
-            }
-
       - name: 📦 Create Tag and Release
         if: steps.version_check.outputs.new_version == 'true'
         uses: softprops/action-gh-release@v2
@@ -137,11 +121,10 @@ jobs:
           body: |
             Automatic download of the official Nintendo Switch firmware version **${{ steps.download.outputs.firmware_version }}**.
             
-            ---
-            
             **Downloaded file details:**
-            
+            ```text
-            ${{ steps.prepare_body.outputs.release_body }}
+            $(cat changelog_body.txt)
+            ```
           files: |
             Firmware ${{ steps.download.outputs.firmware_version }}.zip
         env: